Don't worry about the conflicts, I can fix those when we are done with the review.

fixed comments

@TheCoryBarker I will resolve the conflicts and then check the CI status.

There is an issue with non-Android builds and ANDROID_NDK_HOME needing to be set. For me this is not an issue but for most people this will be. I will look into a fix for this

@TheCoryBarker I merged in the recent changes from main.

ANDROID_NDK_HOME and ANDROID_HOME needing to be set is fixed now, however, the test to build all targets will fail for Android targets. How can we fix this?

You could move the android targets to a subpackage and exclude that target in CI. Let me know of you want me to take a look at that.

I found this as another solution which would probably work better in the long run. Can we update the CI command to run:

bazel query '//... except kind(android.*, //...)' | xargs bazel build

We can do that if nothing else works, but I would like to preserve the assumption that bazel build //... works locally and also that core Jazzer can be built as an external dependency of other Bazel projects. The latter means that packages providing targets relevant for core Jazzer must not load from unrelated rulesets (e.g. rules_android), which may anyway require moving Android targets to a different package.

@TheCoryBarker If you want, I can take a look and propose a fix.

I moved the Android build targets into their own package, but I'm not sure how to exclude them from being built in //..., if you could propose a fix that would be really great

I made it so that Android targets aren't built locally unless requested explicitly, but are built as part of the Linux CI build. I also made it so that the android_configure rule disables itself on Windows.

@TheCoryBarker Windows CI runs are failing since jvm_tooling.cpp unconditionally includes dlfcn.h. Maybe replace the bool android parameter with preprocessor conditionals?

Thank you, I am having a very tough time getting a Windows machine with correct permissions to test my changes on...

Thanks for the suggestion Fabian, I updated to use preprocessor conditionals

@TheCoryBarker I fixed some minor issues, CI looks good now. I left a single comment and will merge when it's resolved.

@TheCoryBarker Thanks for resolving that problem. I squashed the commits, added a commit message and hit merge.